Skip to content

[Transforms][MapArithToComb] Added best-effort lowering for Arith to Comb #9380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianschuiki merged 4 commits into from
Jan 2, 2026
Merged

[Transforms][MapArithToComb] Added best-effort lowering for Arith to Comb #9380

fabianschuiki merged 4 commits into from
Jan 2, 2026

Conversation

@KavyaChopra04
Copy link
Contributor

@KavyaChopra04 KavyaChopra04 commented Dec 23, 2025 •
edited by fabianschuiki
Loading

Resolved failed legalization of arith.fptosi and arith.fptoui. Inadvertently, arith.cmpf also got legalized (because we didn't have an Arith -> Comb lowering for it just yet)
sv-tests errors.txt diff:

>      15 error: 'hw.constant' op requires attribute 'value'
54d54
<       7 error: 'hw.constant' op requires attribute 'value'
75d74
<       4 error: failed to legalize operation 'arith.fptosi' that was explicitly marked illegal
132d130
<       2 error: failed to legalize operation 'arith.cmpf' that was explicitly marked illegal
251,252d248
<       1 error: failed to legalize operation 'arith.uitofp' that was explicitly marked illegal
<       1 error: failed to legalize operation 'arith.sitofp' that was explicitly marked illegal

fabianschuiki
fabianschuiki approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maerhart
maerhart approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KavyaChopra04
Copy link
Contributor Author

KavyaChopra04 commented Dec 31, 2025

Thank you @fabianschuiki and @maerhart . I addressed all comments. This PR is now ready-to-go. Can anyone merge it for me?

@fabianschuiki fabianschuiki merged commit 4e17b05 into llvm:main Jan 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@maerhart maerhart maerhart approved these changes

@uenoku uenoku Awaiting requested review from uenoku

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KavyaChopra04 @fabianschuiki @maerhart