Update installation instructions and run the installation test unconditionally #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
added a commit
to ldionne/llvm-lnt
that referenced
this pull request
Oct 7, 2025
This patch unpins versions in setup.py since they are pinned in requirements.txt. This is effectively a revert of 11c2d9e and 8fc27f4. When we originally unpinned versions from setup.py, some clients were running `setup.py` directly to install `lnt`, which means they started fetching untested and incompatible versions of packages. Since then, we've documented the new installation procedure based on pip and our pinned requirements (in llvm#70).
ldionne
force-pushed
the
review/update-installation-instructions
branch
from
153b6e2 to
92c65d6
Compare
…itionally The installation instructions were based on running `setup.py` directly. However, my understanding is that Python best practices have moved away from doing that and towards using `pip` to install packages in a virtual environment, and using a file like `requirements.txt` to pin dependency versions. This patch documents that updated installation procedure and runs the installation process as a test unconditionally. Fixes llvm#68
ldionne
force-pushed
the
review/update-installation-instructions
branch
from
92c65d6 to
1a35f5a
Compare
|
I will land this since it's required in order to make progress on updating how the various builders are installing |
|
I'll monitor https://lab.llvm.org/buildbot/#/builders/17 |
ldionne
added a commit
to ldionne/llvm-lnt
that referenced
this pull request
Oct 7, 2025
This patch unpins versions in setup.py since they are pinned in requirements.txt. This is effectively a revert of 11c2d9e and 8fc27f4. When we originally unpinned versions from setup.py, some clients were running `setup.py` directly to install `lnt`, which means they started fetching untested and incompatible versions of packages. Since then, we've documented the new installation procedure based on pip and our pinned requirements (in llvm#70).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation instructions were based on running
setup.pydirectly. However, my understanding is that Python best practices have moved away from doing that and towards usingpipto install packages in a virtual environment, and using a file likerequirements.txtto pin dependency versions.This patch documents that updated installation procedure and runs the installation process as a test unconditionally.
It also properly splits the client vs server requirements and tests the installation of both.
Fixes #68