Rewrite project build and metadata using pyproject.toml #88
Conversation
ldionne
force-pushed
the
review/toml-project
branch
5 times, most recently
from
bde2993 to
ec8fc6a
Compare
This patch rewrites the project build configuration using pyproject.toml, which is now the de-facto standard in Python. This single configuration file supersedes setup.py, tox.ini, mypy.ini, etc. I checked the contents of the generated package and made sure they matched exactly (that caught a few issues where I originally excluded some data files). This patch is careful not to change the version of dependencies. In pyproject.toml, we specify minimum package versions for the tool to work, and we provide a requirements.txt file that pins down specific versions for use by end-users. Currently, a few tests are failing if we don't pin exact versions when running them, so we're still pinning exact versions when we run tests via tox. The same holds for the type checker. In the future, we could upgrade towards a proper lockfile instead of manually constructed requirements.txt files. Fixes llvm#77
ldionne
force-pushed
the
review/toml-project
branch
from
acce046 to
07fddd3
Compare
Thanks for the review! I think the TODOs are actually things where we need to fix our tests. For example, |
| COPY . /var/src/lnt | ||
|
|
||
| COPY requirements*.txt setup.py . | ||
| # setup.py uses lnt.__version__ etc. | ||
| COPY lnt/__init__.py lnt/__init__.py | ||
| # we build the cperf extension during install | ||
| COPY lnt/testing/profile lnt/testing/profile | ||
| WORKDIR /var/src/lnt | ||
|
|
||
| RUN pip3 install -r requirements.server.txt \ | ||
| && apk --purge del .build-deps \ | ||
| && mkdir /var/log/lnt | ||
|
|
||
| COPY . . | ||
| COPY docker/docker-entrypoint.sh docker/wait_db /usr/local/bin/ |
There was a problem hiding this comment.
Why did we remove the individual COPYs? This will cause unnecessary layers to be invalidated.
There was a problem hiding this comment.
I think if you just replace the original COPY requirements*.txt setup.py . with COPY requirements*.txt pyproject.toml . we should still be able to avoid reinstalling all the requirements on every build
4 participants
This patch rewrites the project build configuration using pyproject.toml, which is now the de-facto standard in Python. This single configuration file supersedes setup.py, tox.ini, mypy.ini, etc.
I checked the contents of the generated package and made sure they matched exactly (that caught a few issues where I originally excluded some data files).
This patch is careful not to change the version of dependencies. In pyproject.toml, we specify minimum package versions for the tool to work, and we provide a requirements.txt file that pins down specific versions for use by end-users.
Currently, a few tests are failing if we don't pin exact versions when running them, so we're still pinning exact versions when we run tests via tox. The same holds for the type checker.
In the future, we could upgrade towards a proper lockfile instead of manually constructed requirements.txt files.
Fixes #77