[llvm] Validate Parent object before dereference #157460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Daniel Kuts (apach301) ChangesFixes #157449 Full diff: https://github.com/llvm/llvm-project/pull/157460.diff 1 Files Affected:
diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp
index 92f31c909efd4..c3111ebe0f525 100644
--- a/llvm/lib/Object/Archive.cpp
+++ b/llvm/lib/Object/Archive.cpp
@@ -472,10 +472,11 @@ Archive::Child::Child(const Archive *Parent, const char *Start, Error *Err)
return;
}
+ assert(Parent && "Parent can't be nullptr if Start is not a nullptr");
+
Header = Parent->createArchiveMemberHeader(
Start,
- Parent ? Parent->getData().size() - (Start - Parent->getData().data())
- : 0,
+ Parent->getData().size() - (Start - Parent->getData().data()),
Err);
// If we are pointed to real data, Start is not a nullptr, then there must be
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Could you add a test case showing this problem, please? |
That was a static analyzer report, so I don't know how to run this code or have any input data. But the problem is in syntactically inconsistent code: the pointer |
jh7370
approved these changes
Sep 9, 2025
|
@jh7370 are this PR is ready to merge? |
jh7370
approved these changes
Sep 15, 2025
Yes, I think I couldn't merge into project myself. Thank you! |
Done. Please keep an eye open for notification emails from the build bots. The failures probably won't be related to your change, but it's always possible! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/25/builds/11508 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157449