-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[Headers][X86] Enable constexpr handling for MMX/SSE/AVX/AVX512 PMADDWD/PMADDUBSW intrinsics #161563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
4300c53
to
4283909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test coverage in sse2-builtins.c etc.
4283909
to
850c536
Compare
I'm working on it. Sorry for taking such a long time on the issue. 😅 |
6ee2d23
to
43a3a27
Compare
…WD/PMADDUBSW intrinsics
6836847
to
ba867d9
Compare
ba867d9
to
041d1d5
Compare
Thanks @markbhasawut - mark this as "Ready for review" when you're done |
@RKSimon I tried to get this PR a label, but the automate-prs-labels didn't run even I triggered it by updating the branch. Do you have any suggestions? |
Best way is just to use the Update button like I just did - it'll trigger fresh CI builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - cheers!
@RKSimon Thanks for your advice and reviewing! |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/27706 Here is the relevant piece of the build log for the reference
|
This PR updates the PMADDWD/PMADDUBSW builtins to support constant expression handling, by extending the VectorExprEvaluator::VisitCallExpr that handles interp__builtin_ia32_pmadd builtins.
Closes #155392