Skip to content

Conversation

markbhasawut
Copy link
Contributor

This PR updates the PMADDWD/PMADDUBSW builtins to support constant expression handling, by extending the VectorExprEvaluator::VisitCallExpr that handles interp__builtin_ia32_pmadd builtins.

Closes #155392

Copy link

github-actions bot commented Oct 1, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@markbhasawut markbhasawut changed the title [Headers][X86] Enable constexpr handling for MMX/SSE/AVX/AVX512 PMADDWD/PMADDUBSW intrinsics intrinsics [Headers][X86] Enable constexpr handling for MMX/SSE/AVX/AVX512 PMADDWD/PMADDUBSW intrinsics Oct 1, 2025
@RKSimon RKSimon self-requested a review October 6, 2025 13:29
Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test coverage in sse2-builtins.c etc.

@markbhasawut
Copy link
Contributor Author

Missing test coverage in sse2-builtins.c etc.

I'm working on it. Sorry for taking such a long time on the issue. 😅

@markbhasawut markbhasawut force-pushed the x86-pmadd-constexpr branch 2 times, most recently from 6ee2d23 to 43a3a27 Compare October 6, 2025 15:12
@markbhasawut markbhasawut force-pushed the x86-pmadd-constexpr branch 2 times, most recently from 6836847 to ba867d9 Compare October 7, 2025 11:09
@RKSimon
Copy link
Collaborator

RKSimon commented Oct 8, 2025

Thanks @markbhasawut - mark this as "Ready for review" when you're done

@markbhasawut markbhasawut marked this pull request as ready for review October 8, 2025 13:23
@markbhasawut markbhasawut requested a review from RKSimon October 8, 2025 13:23
@markbhasawut
Copy link
Contributor Author

@RKSimon I tried to get this PR a label, but the automate-prs-labels didn't run even I triggered it by updating the branch. Do you have any suggestions?

@RKSimon
Copy link
Collaborator

RKSimon commented Oct 8, 2025

Best way is just to use the Update button like I just did - it'll trigger fresh CI builds

Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - cheers!

@RKSimon RKSimon enabled auto-merge (squash) October 8, 2025 14:26
@markbhasawut
Copy link
Contributor Author

@RKSimon Thanks for your advice and reviewing!

@RKSimon RKSimon merged commit ee19231 into llvm:main Oct 8, 2025
9 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Oct 8, 2025

LLVM Buildbot has detected a new failure on builder clangd-ubuntu-tsan running on clangd-ubuntu-clang while building clang at step 2 "checkout".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/27706

Here is the relevant piece of the build log for the reference
Step 2 (checkout) failure: update (failure)
git version 2.17.1
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': Could not resolve host: github.com
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': Could not resolve host: github.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - add MMX/SSE/AVX/AVX512 PMADDWD/PMADDUBSW intrinsics to be used in constexpr
3 participants