[Headers][X86] Enable constexpr handling for MMX/SSE/AVX/AVX512 PMADDWD/PMADDUBSW intrinsics #161563
+143
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
markbhasawut
changed the title
markbhasawut
force-pushed
the
x86-pmadd-constexpr
branch
from
4300c53 to
4283909
Compare
RKSimon
requested changes
Oct 6, 2025
| case clang::X86::BI__builtin_ia32_pmaddubsw128: | ||
| case clang::X86::BI__builtin_ia32_pmaddubsw256: | ||
| case clang::X86::BI__builtin_ia32_pmaddubsw512: | ||
| return interp__builtin_ia32_pmadd(S, OpPC, Call, BuiltinID); |
There was a problem hiding this comment.
use a callback system like interp__builtin_elementwise_int_binop:
return interp__builtin_ia32_pmadd(S, OpPC, Call,
[](const APSInt &LoLHS, const APSInt &HiLHS, const APSInt &HiRHS, const APSInt &HiRHS) {
unsigned BitWidth = 2 * LHS.getBitWidth();
return (LoLHS.zext(BitWidth) * LoRHS.sext(BitWidth)).sadd_sat((HiLHS.zext(BitWidth) * HiRHS.sext(BitWidth)));
});| case clang::X86::BI__builtin_ia32_pmaddwd128: | ||
| case clang::X86::BI__builtin_ia32_pmaddwd256: | ||
| case clang::X86::BI__builtin_ia32_pmaddwd512: | ||
| return interp__builtin_ia32_pmadd(S, OpPC, Call, BuiltinID); |
There was a problem hiding this comment.
use a callback system like interp__builtin_elementwise_int_binop:
return interp__builtin_ia32_pmadd(S, OpPC, Call,
[](const APSInt &LoLHS, const APSInt &HiLHS, const APSInt &HiRHS, const APSInt &HiRHS) {
unsigned BitWidth = 2 * LHS.getBitWidth();
return (LoLHS.sext(BitWidth) * LoRHS.sext(BitWidth)) + (HiLHS.sext(BitWidth) * HiRHS.sext(BitWidth));
});| case clang::X86::BI__builtin_ia32_pmaddubsw512: | ||
| Mul0 = APSInt(U_LHS0.zext(BitWidth) * RHS0.sext(BitWidth)); | ||
| Mul1 = APSInt(U_LHS1.zext(BitWidth) * RHS1.sext(BitWidth)); | ||
| Result = APSInt(Mul0.sadd_sat(Mul1)); |
There was a problem hiding this comment.
Missing signedness control:
bool DestUnsigned = Call->getType()->isUnsignedIntegerOrEnumerationType();
Result = APSInt(..., DestUnsigned);
| case clang::X86::BI__builtin_ia32_pmaddwd512: | ||
| Mul0 = APSInt(LHS0.sext(BitWidth) * RHS0.sext(BitWidth)); | ||
| Mul1 = APSInt(LHS1.sext(BitWidth) * RHS1.sext(BitWidth)); | ||
| Result = APSInt(Mul0 + Mul1); |
There was a problem hiding this comment.
Missing signedness control
clang/lib/AST/ExprConstant.cpp
Outdated
| case clang::X86::BI__builtin_ia32_pmaddwd512: | ||
| ResultElements.push_back( | ||
| APValue(APSInt(LHS0.sext(BitWidth) * RHS0.sext(BitWidth) + | ||
| LHS1.sext(BitWidth) * RHS1.sext(BitWidth)))); |
There was a problem hiding this comment.
Missing signedness control
clang/lib/AST/ExprConstant.cpp
Outdated
| ResultElements.push_back(APValue( | ||
| APSInt(APInt(U_LHS0.zext(BitWidth)) * | ||
| RHS0.sext(BitWidth).sadd_sat(APInt(U_LHS1.zext(BitWidth)) * | ||
| RHS1.sext(BitWidth))))); |
There was a problem hiding this comment.
Missing signedness control
markbhasawut
force-pushed
the
x86-pmadd-constexpr
branch
from
4283909 to
850c536
Compare
I'm working on it. Sorry for taking such a long time on the issue. 😅 |
…WD/PMADDUBSW intrinsics
markbhasawut
force-pushed
the
x86-pmadd-constexpr
branch
from
850c536 to
6ee2d23
Compare
markbhasawut
force-pushed
the
x86-pmadd-constexpr
branch
from
6ee2d23 to
43a3a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PMADDWD/PMADDUBSW builtins to support constant expression handling, by extending the VectorExprEvaluator::VisitCallExpr that handles interp__builtin_ia32_pmadd builtins.
Closes #155392