Skip to content

Remove device override for operator new when the C++ standard >= 26 #114056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Remove device override for operator new when the C++ standard >= 26 #114056

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db9a3ff
Remove device override for operator new when the C++ standard >= 26
OgnianM Oct 29, 2024
635829e
Change the #if to also check for the libstdc++ constexpr new
OgnianM Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/lib/Headers/cuda_wrappers/new
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,14 @@ __device__ inline void operator delete[](void *ptr,
#endif

// Device overrides for placement new and delete.
#if !(_LIBCPP_STD_VER >= 26 || __cpp_lib_constexpr_new >= 202406L)
__device__ inline void *operator new(__SIZE_TYPE__, void *__ptr) CUDA_NOEXCEPT {
return __ptr;
}
__device__ inline void *operator new[](__SIZE_TYPE__, void *__ptr) CUDA_NOEXCEPT {
return __ptr;
}
#endif
__device__ inline void operator delete(void *, void *) CUDA_NOEXCEPT {}
__device__ inline void operator delete[](void *, void *) CUDA_NOEXCEPT {}

Expand Down
Loading