[Driver] Use heterogenous lookups with std::set (NFC) #115259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heterogenous lookups allow us to call find with StringRef, avoiding a temporary heap allocation of std::string.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) ChangesHeterogenous lookups allow us to call find with StringRef, avoiding a Full diff: https://github.com/llvm/llvm-project/pull/115259.diff 1 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/HIPUtility.cpp b/clang/lib/Driver/ToolChains/HIPUtility.cpp
index c8075cbfe36b35..3f81c3cb0f80e8 100644
--- a/clang/lib/Driver/ToolChains/HIPUtility.cpp
+++ b/clang/lib/Driver/ToolChains/HIPUtility.cpp
@@ -148,8 +148,8 @@ class HIPUndefinedFatBinSymbols {
bool Verbose;
std::set<std::string> FatBinSymbols;
std::set<std::string> GPUBinHandleSymbols;
- std::set<std::string> DefinedFatBinSymbols;
- std::set<std::string> DefinedGPUBinHandleSymbols;
+ std::set<std::string, std::less<>> DefinedFatBinSymbols;
+ std::set<std::string, std::less<>> DefinedGPUBinHandleSymbols;
const std::string FatBinPrefix = "__hip_fatbin";
const std::string GPUBinHandlePrefix = "__hip_gpubin_handle";
@@ -260,11 +260,10 @@ class HIPUndefinedFatBinSymbols {
// Add undefined symbols if they are not in the defined sets
if (isFatBinSymbol &&
- DefinedFatBinSymbols.find(Name.str()) == DefinedFatBinSymbols.end())
+ DefinedFatBinSymbols.find(Name) == DefinedFatBinSymbols.end())
FatBinSymbols.insert(Name.str());
- else if (isGPUBinHandleSymbol &&
- DefinedGPUBinHandleSymbols.find(Name.str()) ==
- DefinedGPUBinHandleSymbols.end())
+ else if (isGPUBinHandleSymbol && DefinedGPUBinHandleSymbols.find(Name) ==
+ DefinedGPUBinHandleSymbols.end())
GPUBinHandleSymbols.insert(Name.str());
}
}
|
Member
|
@llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) ChangesHeterogenous lookups allow us to call find with StringRef, avoiding a Full diff: https://github.com/llvm/llvm-project/pull/115259.diff 1 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/HIPUtility.cpp b/clang/lib/Driver/ToolChains/HIPUtility.cpp
index c8075cbfe36b35..3f81c3cb0f80e8 100644
--- a/clang/lib/Driver/ToolChains/HIPUtility.cpp
+++ b/clang/lib/Driver/ToolChains/HIPUtility.cpp
@@ -148,8 +148,8 @@ class HIPUndefinedFatBinSymbols {
bool Verbose;
std::set<std::string> FatBinSymbols;
std::set<std::string> GPUBinHandleSymbols;
- std::set<std::string> DefinedFatBinSymbols;
- std::set<std::string> DefinedGPUBinHandleSymbols;
+ std::set<std::string, std::less<>> DefinedFatBinSymbols;
+ std::set<std::string, std::less<>> DefinedGPUBinHandleSymbols;
const std::string FatBinPrefix = "__hip_fatbin";
const std::string GPUBinHandlePrefix = "__hip_gpubin_handle";
@@ -260,11 +260,10 @@ class HIPUndefinedFatBinSymbols {
// Add undefined symbols if they are not in the defined sets
if (isFatBinSymbol &&
- DefinedFatBinSymbols.find(Name.str()) == DefinedFatBinSymbols.end())
+ DefinedFatBinSymbols.find(Name) == DefinedFatBinSymbols.end())
FatBinSymbols.insert(Name.str());
- else if (isGPUBinHandleSymbol &&
- DefinedGPUBinHandleSymbols.find(Name.str()) ==
- DefinedGPUBinHandleSymbols.end())
+ else if (isGPUBinHandleSymbol && DefinedGPUBinHandleSymbols.find(Name) ==
+ DefinedGPUBinHandleSymbols.end())
GPUBinHandleSymbols.insert(Name.str());
}
}
|
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
Heterogenous lookups allow us to call find with StringRef, avoiding a temporary heap allocation of std::string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heterogenous lookups allow us to call find with StringRef, avoiding a
temporary heap allocation of std::string.