Skip to content

[Driver] Use heterogenous lookups with std::set (NFC) #115259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[Driver] Use heterogenous lookups with std::set (NFC) #115259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions clang/lib/Driver/ToolChains/HIPUtility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ class HIPUndefinedFatBinSymbols {
bool Verbose;
std::set<std::string> FatBinSymbols;
std::set<std::string> GPUBinHandleSymbols;
std::set<std::string> DefinedFatBinSymbols;
std::set<std::string> DefinedGPUBinHandleSymbols;
std::set<std::string, std::less<>> DefinedFatBinSymbols;
std::set<std::string, std::less<>> DefinedGPUBinHandleSymbols;
const std::string FatBinPrefix = "__hip_fatbin";
const std::string GPUBinHandlePrefix = "__hip_gpubin_handle";

Expand Down Expand Up @@ -260,11 +260,10 @@ class HIPUndefinedFatBinSymbols {

// Add undefined symbols if they are not in the defined sets
if (isFatBinSymbol &&
DefinedFatBinSymbols.find(Name.str()) == DefinedFatBinSymbols.end())
DefinedFatBinSymbols.find(Name) == DefinedFatBinSymbols.end())
FatBinSymbols.insert(Name.str());
else if (isGPUBinHandleSymbol &&
DefinedGPUBinHandleSymbols.find(Name.str()) ==
DefinedGPUBinHandleSymbols.end())
else if (isGPUBinHandleSymbol && DefinedGPUBinHandleSymbols.find(Name) ==
DefinedGPUBinHandleSymbols.end())
GPUBinHandleSymbols.insert(Name.str());
}
}
Expand Down
Loading