Skip to content

[libcxx] [ci] Test mingw environments with msvcrt.dll, too #115783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[libcxx] [ci] Test mingw environments with msvcrt.dll, too #115783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/libcxx-build-and-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,11 @@ jobs:
- { config: clang-cl-no-vcruntime, mingw: false }
- { config: clang-cl-debug, mingw: false }
- { config: clang-cl-static-crt, mingw: false }
- { config: mingw-dll, mingw: true }
- { config: mingw-static, mingw: true }
- { config: mingw-dll-i686, mingw: true }
- { config: mingw-incomplete-sysroot, mingw: true }
- { config: mingw-dll, mingw: true, crt: ucrt }
- { config: mingw-static, mingw: true, crt: ucrt }
- { config: mingw-dll-i686, mingw: true, crt: ucrt }
- { config: mingw-incomplete-sysroot, mingw: true, crt: ucrt }
- { config: mingw-msvcrt, mingw: true, crt: msvcrt }
steps:
- uses: actions/checkout@v4
- name: Install dependencies
Expand All @@ -267,7 +268,7 @@ jobs:
- name: Install llvm-mingw
if: ${{ matrix.mingw == true }}
run: |
curl -LO https://github.com/mstorsjo/llvm-mingw/releases/download/20240606/llvm-mingw-20240606-ucrt-x86_64.zip
curl -LO https://github.com/mstorsjo/llvm-mingw/releases/download/20240606/llvm-mingw-20240606-${{matrix.crt}}-x86_64.zip
powershell Expand-Archive llvm-mingw*.zip -DestinationPath .
del llvm-mingw*.zip
mv llvm-mingw* c:\llvm-mingw
Expand Down
9 changes: 9 additions & 0 deletions libcxx/utils/ci/run-buildbot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,15 @@ mingw-incomplete-sysroot)
step "Building the runtimes"
${NINJA} -vC "${BUILD_DIR}"
;;
mingw-msvcrt)
# All tests don't pass in msvcrt based configurations (and we don't have
# the right XFAIL markings for it yet), thus initially only test building.
clean
generate-cmake \
-C "${MONOREPO_ROOT}/libcxx/cmake/caches/MinGW.cmake"
step "Building the runtimes"
${NINJA} -vC "${BUILD_DIR}"
;;
aix)
clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \
Expand Down
Loading