Skip to content

[lldb] Refactor helper by using iterators and in-place edits (NFC) #116876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[lldb] Refactor helper by using iterators and in-place edits (NFC) #116876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions lldb/source/Utility/DiagnosticsRendering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,23 +132,16 @@ void RenderDiagnosticDetails(Stream &stream,
stream << '\n';

// Reverse the order within groups of diagnostics that are on the same column.
auto group = [](const std::vector<DiagnosticDetail> &details) {
uint16_t column = 0;
std::vector<DiagnosticDetail> result, group;
for (auto &d : details) {
if (d.source_location->column == column) {
group.push_back(d);
continue;
}
result.insert(result.end(), group.rbegin(), group.rend());
group.clear();
column = d.source_location->column;
group.push_back(d);
auto group = [](std::vector<DiagnosticDetail> &details) {
for (auto it = details.begin(), end = details.end(); it != end;) {
auto eq_end = std::find_if(it, end, [&](const DiagnosticDetail &d) {
return d.source_location->column != it->source_location->column;
});
std::reverse(it, eq_end);
it = eq_end;
}
result.insert(result.end(), group.rbegin(), group.rend());
return result;
};
remaining_details = group(remaining_details);
group(remaining_details);

// Work through each detail in reverse order using the vector/stack.
bool did_print = false;
Expand Down
Loading