[NFCI][test] Use lit.local.cfg in test/MachineVerifier/RISCV to gate tests #118217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests 87cc4b4 added `REQUIRES: riscv64-registered-target` to the only test in this directory. It seems better (and also reflects what we do elsewhere, including in the AMDGPU/ subdir in MachineVerifier) to gate for all files in the directory via lit.local.cfg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
87cc4b4 added
REQUIRES: riscv64-registered-targetto the only test in this directory. It seems better (and also reflects what we do elsewhere, including in the AMDGPU/ subdir in MachineVerifier) to gate for all files in the directory via lit.local.cfg.I'd normally directly commit such a simple change, but just wanted to make sure there wasn't a reason to prefer it the way it was done before.