Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ namespace clang::tidy::readability {
/// a call to `empty()`.
///
/// The emptiness of a container should be checked using the `empty()` method
/// instead of the `size()` method. It shows clearer intent to use `empty()`.
/// Furthermore some containers may implement the `empty()` method but not
/// implement the `size()` method. Using `empty()` whenever possible makes it
/// easier to switch to another container in the future.
/// instead of the `size()`/`length()` method. It shows clearer intent to use
/// `empty()`. Furthermore some containers may implement the `empty()` method
/// but not implement the `size()` or `length()` method. Using `empty()`
/// whenever possible makes it easier to switch to another container in the
/// future.
Comment on lines +22 to +25
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both for your approval, @HerrCai0907 and @carlosgalvezp. I'm considering to propose mentioning std::forward_list here, as it is the one STL container that does not implement size(). But maybe first wait for this one (#118459) to get merged...

class ContainerSizeEmptyCheck : public ClangTidyCheck {
public:
ContainerSizeEmptyCheck(StringRef Name, ClangTidyContext *Context);
Expand Down
Loading