Skip to content

[offload] [test] Skip amdgcn/nvptx tests if detected arch is not built #119006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[offload] [test] Skip amdgcn/nvptx tests if detected arch is not built #119006

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5dc456
[offload] [test] Skip amdgcn/nvptx tests if detected arch is not built
mgorny Dec 6, 2024
8492bda
[offload] Move test gpu arch checks into plugins-nextgen
mgorny Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions offload/DeviceRTL/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ elseif(LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "auto" OR
"${LIBOMPTARGET_NVPTX_DETECTED_ARCH_LIST};${LIBOMPTARGET_AMDGPU_DETECTED_ARCH_LIST}")
endif()
list(REMOVE_DUPLICATES LIBOMPTARGET_DEVICE_ARCHITECTURES)
# for tests
set(LIBOMPTARGET_EXPANDED_DEVICE_ARCHITECTURES ${LIBOMPTARGET_DEVICE_ARCHITECTURES}
PARENT_SCOPE)

set(include_files
${include_directory}/Allocator.h
Expand Down
14 changes: 14 additions & 0 deletions offload/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ string(REGEX MATCHALL "([^\ ]+\ |[^\ ]+$)" SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM
foreach(CURRENT_TARGET IN LISTS SYSTEM_TARGETS)
string(STRIP "${CURRENT_TARGET}" CURRENT_TARGET)

if(CURRENT_TARGET MATCHES "^amdgcn" AND
NOT "${LIBOMPTARGET_AMDGPU_DETECTED_ARCH_LIST}"
IN_LIST LIBOMPTARGET_EXPANDED_DEVICE_ARCHITECTURES)
message(WARNING "Detected AMDGPU arch ${LIBOMPTARGET_AMDGPU_DETECTED_ARCH_LIST} "
"not in built arch list, ${CURRENT_TARGET} tests will be skipped")
continue()
elseif(CURRENT_TARGET MATCHES "^nvptx" AND
NOT "${LIBOMPTARGET_DEP_CUDA_ARCH}"
IN_LIST LIBOMPTARGET_EXPANDED_DEVICE_ARCHITECTURES)
message(WARNING "Detected NVPTX arch ${LIBOMPTARGET_DEP_CUDA_ARCH} "
"not in built arch list, ${CURRENT_TARGET} tests will be skipped")
continue()
endif()

add_offload_testsuite(check-libomptarget-${CURRENT_TARGET}
"Running libomptarget tests"
${CMAKE_CURRENT_BINARY_DIR}/${CURRENT_TARGET}
Expand Down
Loading