Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Dec 13, 2024

Pick the minimum complexity required for tests to pass instead of
a giant debug value of 1000.

…atterns

Positively boost the 2 operand forms instead.
Pick the minimum complexity required for tests to pass instead of
a giant debug value of 1000.
Copy link
Contributor Author

arsenm commented Dec 13, 2024

@llvmbot
Copy link
Member

llvmbot commented Dec 13, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

Pick the minimum complexity required for tests to pass instead of
a giant debug value of 1000.


Full diff: https://github.com/llvm/llvm-project/pull/119796.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SIInstructions.td (+1-1)
diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td
index bc25d75131cc35..9bd04b939c8a55 100644
--- a/llvm/lib/Target/AMDGPU/SIInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -3055,7 +3055,7 @@ def : GCNPat<
    (V_BFREV_B32_e64 (i32 (EXTRACT_SUBREG VReg_64:$a, sub0))), sub1)>;
 
 // If fcanonicalize's operand is implicitly canonicalized, we only need a copy.
-let AddedComplexity = 1000 in {
+let AddedComplexity = 8 in {
 foreach vt = [f16, v2f16, f32, v2f32, f64] in {
   def : GCNPat<
     (fcanonicalize (vt is_canonicalized:$src)),

Base automatically changed from users/arsenm/gfx950/avoid-negative-added-complexity-fmaximum3-patterns to main December 13, 2024 21:17
@arsenm
Copy link
Contributor Author

arsenm commented Jan 6, 2025

ping

@arsenm arsenm merged commit 7e2ed35 into main Jan 7, 2025
12 checks passed
@arsenm arsenm deleted the users/arsenm/amdgpu-reduce-canonicalize-addedcomplexity-1000 branch January 7, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants