[HLSL][NFC] Fix static analyzer concerns #120090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler generated special functions may behave incorrectly. Delete explicitly copy constructor and copy assignment operator to avoid potential errors.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Mariya Podchishchaeva (Fznamznon) ChangesClass BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler generated special functions may behave incorrectly. Delete explicitly copy constructor and copy assignment operator to avoid potential errors. Full diff: https://github.com/llvm/llvm-project/pull/120090.diff 1 Files Affected:
diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp b/clang/lib/Sema/HLSLExternalSemaSource.cpp
index 79fc2751b73812..f21069d7d64ee4 100644
--- a/clang/lib/Sema/HLSLExternalSemaSource.cpp
+++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp
@@ -546,6 +546,9 @@ struct BuiltinTypeMethodBuilder {
public:
~BuiltinTypeMethodBuilder() { finalizeMethod(); }
+ BuiltinTypeMethodBuilder(BuiltinTypeMethodBuilder &Other) = delete;
+ BuiltinTypeMethodBuilder &operator=(BuiltinTypeMethodBuilder &Other) = delete;
+
Expr *getResourceHandleExpr() {
// The first statement added to a method or access to 'this' creates the
// declaration.
|
cor3ntin
reviewed
Dec 17, 2024
Comment on lines
549
to
550
| BuiltinTypeMethodBuilder(BuiltinTypeMethodBuilder &Other) = delete; | ||
| BuiltinTypeMethodBuilder &operator=(BuiltinTypeMethodBuilder &Other) = delete; |
Contributor
There was a problem hiding this comment.
Suggested change
| BuiltinTypeMethodBuilder(BuiltinTypeMethodBuilder &Other) = delete; | |
| BuiltinTypeMethodBuilder &operator=(BuiltinTypeMethodBuilder &Other) = delete; | |
| BuiltinTypeMethodBuilder(const BuiltinTypeMethodBuilder &Other) = delete; | |
| BuiltinTypeMethodBuilder &operator=(const BuiltinTypeMethodBuilder &Other) = delete; |
Member
|
Thank you @Fznamznon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler generated special functions may behave incorrectly. Delete explicitly copy constructor and copy assignment operator to avoid potential errors.