Skip to content

[HLSL][NFC] Fix static analyzer concerns #120090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fznamznon merged 2 commits into from
Dec 17, 2024
Merged

[HLSL][NFC] Fix static analyzer concerns #120090

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85b64f
[HLSL][NFC] Fix static analyzer concerns
Fznamznon Dec 16, 2024
0ee26bd
Fix a nit
Fznamznon Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/lib/Sema/HLSLExternalSemaSource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,9 @@ struct BuiltinTypeMethodBuilder {
public:
~BuiltinTypeMethodBuilder() { finalizeMethod(); }

BuiltinTypeMethodBuilder(BuiltinTypeMethodBuilder &Other) = delete;
BuiltinTypeMethodBuilder &operator=(BuiltinTypeMethodBuilder &Other) = delete;
Copy link
Contributor

@cor3ntin cor3ntin Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BuiltinTypeMethodBuilder(BuiltinTypeMethodBuilder &Other) = delete;
BuiltinTypeMethodBuilder &operator=(BuiltinTypeMethodBuilder &Other) = delete;
BuiltinTypeMethodBuilder(const BuiltinTypeMethodBuilder &Other) = delete;
BuiltinTypeMethodBuilder &operator=(const BuiltinTypeMethodBuilder &Other) = delete;


Expr *getResourceHandleExpr() {
// The first statement added to a method or access to 'this' creates the
// declaration.
Expand Down
Loading