Introduce virtual interface for lattices and remove dependency on llvm::Any.
#120967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ymand
force-pushed
the
rm-dyn
branch
3 times, most recently
from
3792a38 to
2273b56
Compare
…vm::Any`. This PR has 2 related goals: *Remove dependency on `llvm::Any`*. For some platforms, use of `llvm::Any` forces users to explicitly define internal details related to `Any`. Aside from aesthetics, this places an obscure requirement on lattice implementers. We prefer to use LLVM's (explicit) RTTI framework instead. *Introduce virtual interface for lattices*. Currently, we implicitly define the interface for lattices, because the interface to analyses is fully captured in templates. This PR moves to an explicit, virtual interface. We combine these two changes in a single PR because they are closely related: we use the new lattice interface as the basis of an open type hierarchy that embeds RTTI for safe interfacing with the dataflow engine. As a side-effect, we are able to greatly simplify the interface of `DataflowAnalysis` and collapse the distinction between it and `TypeErasedDataflowAnalysis`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 related goals:
Remove dependency on
llvm::Any. For some platforms, use ofllvm::Anyforces users to explicitly define internal details related to
Any. Aside fromaesthetics, this places an obscure requirement on lattice implementers. We
prefer to use LLVM's (explicit) RTTI framework instead.
Introduce virtual interface for lattices. Currently, we implicitly define the
interface for lattices, because the interface to analyses is fully captured in
templates. This PR moves to an explicit, virtual interface.
We combine these two changes in a single PR because they are closely related: we
use the new lattice interface as the basis of an open type hierarchy that embeds
RTTI for safe interfacing with the dataflow engine.