[NFC][modules] Create objects on the stack

[vitalybuka]

ClangTool change to fix memory leak.
FixedCompilationDatabase changed just to makes it simpler.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: Vitaly Buka (vitalybuka)

Changes

ClangTool was leaking.
FixedCompilationDatabase just makes it simpler.

---

Full diff: https://github.com/llvm/llvm-project/pull/124034.diff

1 Files Affected:

• (modified) clang-tools-extra/modularize/CoverageChecker.cpp (+4-4)

diff --git a/clang-tools-extra/modularize/CoverageChecker.cpp b/clang-tools-extra/modularize/CoverageChecker.cpp
index b536ee00497c03..fe6711398ab7dc 100644
--- a/clang-tools-extra/modularize/CoverageChecker.cpp
+++ b/clang-tools-extra/modularize/CoverageChecker.cpp
@@ -278,15 +278,15 @@ CoverageChecker::collectUmbrellaHeaderHeaders(StringRef UmbrellaHeaderName) {
     sys::fs::current_path(PathBuf);
 
   // Create the compilation database.
-  std::unique_ptr<CompilationDatabase> Compilations;
-  Compilations.reset(new FixedCompilationDatabase(Twine(PathBuf), CommandLine));
+  FixedCompilationDatabase Compilations(Twine(PathBuf), CommandLine);
 
   std::vector<std::string> HeaderPath;
   HeaderPath.push_back(std::string(UmbrellaHeaderName));
 
   // Create the tool and run the compilation.
-  ClangTool Tool(*Compilations, HeaderPath);
-  int HadErrors = Tool.run(new CoverageCheckerFrontendActionFactory(*this));
+  ClangTool Tool(Compilations, HeaderPath);
+  CoverageCheckerFrontendActionFactory ActionFactory(*this);
+  int HadErrors = Tool.run(&ActionFactory);
 
   // If we had errors, exit early.
   return !HadErrors;