Skip to content

[NFC][modules] Create objects on the stack #124034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitalybuka merged 2 commits into from
Jan 23, 2025
Merged

[NFC][modules] Create objects on the stack #124034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd4ff6b
[𝘀𝗽𝗿] initial version
vitalybuka Jan 23, 2025
c753eea
rebase
vitalybuka Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clang-tools-extra/modularize/CoverageChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,15 +278,15 @@ CoverageChecker::collectUmbrellaHeaderHeaders(StringRef UmbrellaHeaderName) {
sys::fs::current_path(PathBuf);

// Create the compilation database.
std::unique_ptr<CompilationDatabase> Compilations;
Compilations.reset(new FixedCompilationDatabase(Twine(PathBuf), CommandLine));
FixedCompilationDatabase Compilations(Twine(PathBuf), CommandLine);

std::vector<std::string> HeaderPath;
HeaderPath.push_back(std::string(UmbrellaHeaderName));

// Create the tool and run the compilation.
ClangTool Tool(*Compilations, HeaderPath);
int HadErrors = Tool.run(new CoverageCheckerFrontendActionFactory(*this));
ClangTool Tool(Compilations, HeaderPath);
CoverageCheckerFrontendActionFactory ActionFactory(*this);
int HadErrors = Tool.run(&ActionFactory);

// If we had errors, exit early.
return !HadErrors;
Expand Down
Loading