Skip to content

Conversation

@mstorsjo
Copy link
Member

@mstorsjo mstorsjo commented Feb 6, 2025

This test does succeed in MinGW configurations.

….cpp

This test does succeed in MinGW configurations.
@mstorsjo mstorsjo requested a review from zmodem February 6, 2025 21:53
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 6, 2025
@mstorsjo
Copy link
Member Author

mstorsjo commented Feb 6, 2025

CC @DKLoehr

@llvmbot
Copy link
Member

llvmbot commented Feb 6, 2025

@llvm/pr-subscribers-clang

Author: Martin Storsjö (mstorsjo)

Changes

This test does succeed in MinGW configurations.


Full diff: https://github.com/llvm/llvm-project/pull/126139.diff

1 Files Affected:

  • (modified) clang/test/SemaCXX/unique_object_duplication.cpp (+2-2)
diff --git a/clang/test/SemaCXX/unique_object_duplication.cpp b/clang/test/SemaCXX/unique_object_duplication.cpp
index 8a19fb7b81187a..4b41bfbfdc2f75 100644
--- a/clang/test/SemaCXX/unique_object_duplication.cpp
+++ b/clang/test/SemaCXX/unique_object_duplication.cpp
@@ -1,7 +1,7 @@
 // RUN: %clang_cc1 -fsyntax-only -verify=hidden -Wunique-object-duplication -fvisibility=hidden -Wno-unused-value %s
 // RUN: %clang_cc1 -fsyntax-only -verify -Wunique-object-duplication -Wno-unused-value %s
-// The check is currently disabled on windows. The test should fail because we're not getting the expected warnings.
-// XFAIL: target={{.*}}-windows{{.*}}, {{.*}}-ps{{(4|5)(-.+)?}}
+// The check is currently disabled on windows in MSVC-like environments. The test should fail because we're not getting the expected warnings.
+// XFAIL: target={{.*}}-windows-msvc, {{.*}}-ps{{(4|5)(-.+)?}}
 
 #include "unique_object_duplication.h"
 

Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mstorsjo mstorsjo merged commit 2a6cfbd into llvm:main Feb 7, 2025
10 checks passed
@mstorsjo mstorsjo deleted the clang-test-xfail-mingw branch February 7, 2025 13:30
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
….cpp (llvm#126139)

This test does succeed in MinGW configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants