[clang][dataflow] Add test repro for a crash

[jvoung]

An issue with looking up the "this" when a default init of
field2 refers to field1.

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 6e7da07c73c179396e21fb729ac14d6b2a1c3152 cbee7237639a7a9c070a1a1b018af115914091b7 --extensions cpp -- clang/lib/AST/ParentMap.cpp clang/lib/Analysis/CFG.cpp clang/lib/Analysis/ReachableCode.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/test/AST/ast-dump-recovery.cpp clang/test/Analysis/lifetime-extended-regions.cpp clang/test/SemaCXX/cxx2c-placeholder-vars.cpp clang/test/SemaCXX/warn-unreachable.cpp clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp

View the diff from clang-format here.

diff --git a/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp b/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
index 4a5eeb9551..5dee2e582e 100644
--- a/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
+++ b/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
@@ -2013,8 +2013,7 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred,
         ProgramStateRef State = I->getState();
         State = State->BindExpr(S, LCtx, *ConstantVal);
         if (IsTemporary)
-          State = createTemporaryRegionIfNeeded(State, LCtx,
-                                                cast<Expr>(S),
+          State = createTemporaryRegionIfNeeded(State, LCtx, cast<Expr>(S),
                                                 cast<Expr>(S));
         Bldr2.generateNode(S, I, State);
       }