Skip to content

[mlir][docs] Add docs on canonicalizers being folders or patterns #129517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

[mlir][docs] Add docs on canonicalizers being folders or patterns #129517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63b5096
[mlir][docs] Add docs on canonicalizers being folders or patterns
Groverkss Mar 3, 2025
3f23b4d
Address comment
Groverkss Mar 3, 2025
d28d2f9
address comments
Groverkss Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mlir/docs/Canonicalization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,8 @@ Operation *MyDialect::materializeConstant(OpBuilder &builder, Attribute value,
...
}
```

### When to use the `fold` method vs `RewriterPattern`s for canonicalizations

A canonicalization should always be implemented as a `fold` method if it can
be, otherwise it should be implemented as a `RewritePattern`.