Add -lpthread for powerpc64le shared libs build #132265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZarkoT
requested review from
amy-kwan,
chandlerc,
hyp,
kamaub and
kazutakahirata
ZarkoT
referenced
this pull request
Mar 20, 2025
This patch fixes: clang/lib/Tooling/DependencyScanning/InProcessModuleCache.cpp:38:5: error: 'shared_lock' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] clang/lib/Tooling/DependencyScanning/InProcessModuleCache.cpp:68:7: error: 'lock_guard' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
thesamesam
reviewed
Mar 20, 2025
|
|
||
| #The shared libs build for Linux on PowerPC requires -lpthread | ||
| if(BUILD_SHARED_LIBS AND ${CMAKE_SYSTEM_NAME} MATCHES "Linux" AND LLVM_HOST_TRIPLE MATCHES "powerpc*") | ||
| append("-lpthread" |
Member
There was a problem hiding this comment.
You want to add a dependency on Threads::Threads instead.
Contributor
Author
There was a problem hiding this comment.
Thank you.
Though looks like the build is fixed by some other changes already: https://lab.llvm.org/buildbot/#/builders/145/builds/5917.
I'll close this PR in this case.
Contributor
Author
|
Build fixed by: 15ad84f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ppc64le shared libs build: https://lab.llvm.org/buildbot/#/builders/145/builds/5759/steps/5/logs/stdio
This may be overkill and I'm open to suggestions on making this more specific.