Skip to content

Add -lpthread for powerpc64le shared libs build #132265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZarkoT wants to merge 1 commit into from
Closed

Add -lpthread for powerpc64le shared libs build #132265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llvm/cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,6 +1320,13 @@ if(LLVM_LINK_LLVM_DYLIB AND LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
message(FATAL_ERROR "LLVM_LINK_LLVM_DYLIB not compatible with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS")
endif()

#The shared libs build for Linux on PowerPC requires -lpthread
if(BUILD_SHARED_LIBS AND ${CMAKE_SYSTEM_NAME} MATCHES "Linux" AND LLVM_HOST_TRIPLE MATCHES "powerpc*")
append("-lpthread"
Copy link
Member

@thesamesam thesamesam Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to add a dependency on Threads::Threads instead.

Copy link
Contributor Author

@ZarkoT ZarkoT Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Though looks like the build is fixed by some other changes already: https://lab.llvm.org/buildbot/#/builders/145/builds/5917.

I'll close this PR in this case.

CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
endif()


# By default we should enable LLVM_ENABLE_IDE only for multi-configuration
# generators. This option disables optional build system features that make IDEs
# less usable.
Expand Down