-
Notifications
You must be signed in to change notification settings - Fork 15.4k
llvm-reduce: Avoid invalid reductions on x86_intrcc #133396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm-reduce: Avoid invalid reductions on x86_intrcc #133396
Conversation
fhahn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
| Module &Program = WorkItem.getModule(); | ||
| std::vector<Argument *> InitArgsToKeep; | ||
| std::vector<Function *> Funcs; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated whitespace change
If there are arguments, the first one must be byval.
8afdd1b to
0d5c6be
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/17/builds/6841 Here is the relevant piece of the build log for the reference |

If there are arguments, the first one must be byval.