Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 28, 2025

If there are arguments, the first one must be byval.

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Module &Program = WorkItem.getModule();
std::vector<Argument *> InitArgsToKeep;
std::vector<Function *> Funcs;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated whitespace change

Suggested change

Copy link
Contributor Author

arsenm commented Mar 28, 2025

Merge activity

  • Mar 28, 12:07 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 28, 12:09 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 28, 12:11 PM EDT: A user merged this pull request with Graphite.

If there are arguments, the first one must be byval.
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/avoid-invalid-reduction-x86_intrcc branch from 8afdd1b to 0d5c6be Compare March 28, 2025 16:08
@arsenm arsenm merged commit a33d789 into main Mar 28, 2025
6 of 10 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/avoid-invalid-reduction-x86_intrcc branch March 28, 2025 16:11
@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 28, 2025

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve-vla running on linaro-g3-04 while building llvm at step 7 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/17/builds/6841

Here is the relevant piece of the build log for the reference
Step 7 (ninja check 1) failure: stage 1 checked (failure)
...
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/bin/ld64.lld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/bin/wasm-ld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/discovery.py:276: warning: input '/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/runtimes/runtimes-bins/compiler-rt/test/interception/Unit' contained no tests
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/discovery.py:276: warning: input '/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/Unit' contained no tests
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using ld.lld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/bin/ld.lld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/bin/lld-link
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/bin/ld64.lld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/bin/wasm-ld
-- Testing: 97442 tests, 64 workers --
UNRESOLVED: Flang :: Driver/slp-vectorize.ll (1 of 97442)
******************** TEST 'Flang :: Driver/slp-vectorize.ll' FAILED ********************
Test has no 'RUN:' line
********************
PASS: AddressSanitizer-Unit :: ./Asan-aarch64-inline-Noinst-Test/12/16 (2 of 97442)
PASS: AddressSanitizer-Unit :: ./Asan-aarch64-calls-Noinst-Test/12/16 (3 of 97442)
PASS: UBSan-MemorySanitizer-aarch64 :: TestCases/ImplicitConversion/unsigned-integer-truncation-ignorelist.c (4 of 97442)
PASS: ThreadSanitizer-aarch64 :: force_background_thread.cpp (5 of 97442)
PASS: LLVM-Unit :: Support/./SupportTests/83/95 (6 of 97442)
PASS: UBSan-AddressSanitizer-aarch64 :: TestCases/ImplicitConversion/unsigned-integer-truncation-ignorelist.c (7 of 97442)
PASS: Clang :: CodeGen/X86/sse-builtins-constrained.c (8 of 97442)
PASS: Clang :: Driver/clang_f_opts.c (9 of 97442)
PASS: UBSan-AddressSanitizer-aarch64 :: TestCases/ImplicitConversion/signed-integer-truncation-ignorelist.c (10 of 97442)
PASS: LLVM :: CodeGen/ARM/build-attributes.ll (11 of 97442)
PASS: libFuzzer-aarch64-default-Linux :: fuzzer-timeout.test (12 of 97442)
PASS: UBSan-ThreadSanitizer-aarch64 :: TestCases/ImplicitConversion/unsigned-integer-truncation-ignorelist.c (13 of 97442)
PASS: UBSan-ThreadSanitizer-aarch64 :: TestCases/ImplicitConversion/signed-integer-truncation-ignorelist.c (14 of 97442)
PASS: Clang :: OpenMP/target_teams_distribute_codegen_registration.cpp (15 of 97442)
PASS: Clang :: Driver/linux-ld.c (16 of 97442)
PASS: Clang :: OpenMP/target_parallel_for_codegen_registration.cpp (17 of 97442)
PASS: Clang :: OpenMP/target_teams_distribute_simd_codegen_registration.cpp (18 of 97442)
PASS: ThreadSanitizer-aarch64 :: stress.cpp (19 of 97442)
PASS: Clang :: OpenMP/target_parallel_for_simd_codegen_registration.cpp (20 of 97442)
PASS: LLVM :: CodeGen/AMDGPU/llvm.amdgcn.permlane.ll (21 of 97442)
PASS: Clang :: Preprocessor/predefined-arch-macros.c (22 of 97442)
PASS: libFuzzer-aarch64-default-Linux :: value-profile-cmp.test (23 of 97442)
PASS: Clang :: CodeGen/X86/sse2-builtins.c (24 of 97442)
PASS: Clang :: Analysis/runtime-regression.c (25 of 97442)
PASS: ThreadSanitizer-aarch64 :: deadlock_detector_stress_test.cpp (26 of 97442)
PASS: DataFlowSanitizer-aarch64 :: custom.cpp (27 of 97442)
PASS: Clang :: Headers/arm-neon-header.c (28 of 97442)
PASS: Clang :: OpenMP/target_teams_distribute_parallel_for_simd_codegen_registration.cpp (29 of 97442)
PASS: Clang :: CodeGen/X86/rot-intrinsics.c (30 of 97442)
PASS: Clang :: Preprocessor/arm-target-features.c (31 of 97442)
PASS: HWAddressSanitizer-aarch64 :: TestCases/Linux/create-thread-stress.cpp (32 of 97442)
PASS: SanitizerCommon-hwasan-aarch64-Linux :: Linux/signal_segv_handler.cpp (33 of 97442)
PASS: Clang :: Preprocessor/aarch64-target-features.c (34 of 97442)
PASS: Clang :: CodeGen/X86/avx-builtins.c (35 of 97442)
PASS: ThreadSanitizer-aarch64 :: signal_thread.cpp (36 of 97442)
PASS: SanitizerCommon-asan-aarch64-Linux :: Linux/signal_segv_handler.cpp (37 of 97442)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants