Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 28, 2025

In undefined mismatch cases, this was fixing the callsite to use the calling
convention of the new function. Preserve the original wrong callsite's calling
convention.

@arsenm arsenm marked this pull request as ready for review March 28, 2025 10:17
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch from d7da274 to 7e93188 Compare March 28, 2025 10:22
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv branch from 0e49d45 to 450bceb Compare March 28, 2025 10:22
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch from 7e93188 to 1e3bc8b Compare March 28, 2025 16:29
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv branch from 450bceb to dc033ac Compare March 28, 2025 16:30
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch from 1e3bc8b to 3962ce4 Compare March 28, 2025 16:39
Base automatically changed from users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments to main March 28, 2025 16:41
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv branch from dc033ac to c88f4ef Compare March 28, 2025 16:43
…guments

In undefined mismatch cases, this was fixing the callsite to use the calling
convention of the new function. Preserve the original wrong callsite's calling
convention.
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv branch from c88f4ef to abe9ab2 Compare March 28, 2025 16:48
Copy link
Contributor Author

arsenm commented Mar 28, 2025

Merge activity

  • Mar 28, 12:49 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 28, 12:51 PM EDT: A user merged this pull request with Graphite.

@arsenm arsenm merged commit 44e3735 into main Mar 28, 2025
6 of 9 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv branch March 28, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants