-
Notifications
You must be signed in to change notification settings - Fork 15.4k
llvm-reduce: Preserve original callsite calling conv when removing arguments #133411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arsenm
merged 1 commit into
main
from
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
Mar 28, 2025
Merged
llvm-reduce: Preserve original callsite calling conv when removing arguments #133411
arsenm
merged 1 commit into
main
from
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
Mar 28, 2025
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2025
Contributor
Author
d7da274 to
7e93188
Compare
0e49d45 to
450bceb
Compare
This was referenced Mar 28, 2025
shiltian
approved these changes
Mar 28, 2025
7e93188 to
1e3bc8b
Compare
450bceb to
dc033ac
Compare
1e3bc8b to
3962ce4
Compare
Base automatically changed from
users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments
to
main
March 28, 2025 16:41
dc033ac to
c88f4ef
Compare
…guments In undefined mismatch cases, this was fixing the callsite to use the calling convention of the new function. Preserve the original wrong callsite's calling convention.
c88f4ef to
abe9ab2
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

In undefined mismatch cases, this was fixing the callsite to use the calling
convention of the new function. Preserve the original wrong callsite's calling
convention.