[libc++][CI] Improves updating Docker image. #134497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesThis makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image. Full diff: https://github.com/llvm/llvm-project/pull/134497.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index af8ebd4d405f2..e0591f0224102 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -44,6 +44,10 @@
ARG BASE_IMAGE
FROM $BASE_IMAGE AS builder-base
+# Changing this file causes a rebuild of the image in a GitHub action.
+# The date uses the ISO format YYYY-MM-DD.
+RUN echo "Last forced update executed on 2025-04-05."
+
# Make sure apt-get doesn't try to prompt for stuff like our time zone, etc.
ENV DEBIAN_FRONTEND=noninteractive
|
ldionne
approved these changes
Apr 8, 2025
mordante
added a commit
that referenced
this pull request
May 4, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This image was updated in llvm#132271. Due to issues with upstream packages, it uses llvm#134497 instead.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
This makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
This image was updated in llvm#132271. Due to issues with upstream packages, it uses llvm#134497 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image.