[libc] Add dthorn as maintainer for allocator on baremetal #135203
Conversation
|
@llvm/pr-subscribers-libc Author: Daniel Thornburgh (mysterymath) ChangesThis was on request from other maintainers, given that I've been de-facto acting as maintainer of the baremetal allocator stuff. Let me know if this is too fine-grained to track. Full diff: https://github.com/llvm/llvm-project/pull/135203.diff 1 Files Affected:
diff --git a/libc/Maintainers.rst b/libc/Maintainers.rst
index 8f3c251a0edb1..3f6f8076f379e 100644
--- a/libc/Maintainers.rst
+++ b/libc/Maintainers.rst
@@ -22,6 +22,11 @@ Baremetal
| Petr Hosek
| phosek\@google.com (email), `petrhosek <https://github.com/petrhosek>`_ (github)
+Allocator (Baremetal)
+---------
+| Daniel Thornburgh
+| dthorn\@google.com (email), `mysterymath <https://github.com/mysterymath>`_ (github)
+
Fixed Point
-----------
| Leonard Chan
|
This was on request from other maintainers, given that I've been de-facto acting as maintainer of the baremetal allocator stuff. Let me know if this is too fine-grained to track.
mysterymath
force-pushed
the
libc/maintainers
branch
from
2d1a235 to
e7f6ae7
Compare
| | Petr Hosek | ||
| | phosek\@google.com (email), `petrhosek <https://github.com/petrhosek>`_ (github) | ||
| Baremetal (Allocator) |
There was a problem hiding this comment.
We talked about making the allocator usable in non-baremetal environments as well (ideally we'd have a CMake option to select between system, libc and Scudo alllocator) so I wonder if this should say just "Allocator"?
There was a problem hiding this comment.
Either is fine with me. Whatever you're up for claiming.
There was a problem hiding this comment.
We've talked about this off and on, and IIRC there was a loose consensus that some other allocator should be the default for hosted OS-es. (Probably SCUDO.) It's just that it should be automatically configured if you don't ask for something different. The libc allocator will always be terrible in basically any non-embedded context, so I'm comfortable calling it a baremetal allocator (at least until something changes).
michaelrj-google
left a comment
michaelrj-google
left a comment
There was a problem hiding this comment.
Approved to join as a maintainer, I'd say leave this open for comments for a bit in case there are any comments but if not feel free to merge.
| | Petr Hosek | ||
| | phosek\@google.com (email), `petrhosek <https://github.com/petrhosek>`_ (github) | ||
| Baremetal (Allocator) |
There was a problem hiding this comment.
Either is fine with me. Whatever you're up for claiming.
libc/Maintainers.rst
Outdated
| | phosek\@google.com (email), `petrhosek <https://github.com/petrhosek>`_ (github) | ||
| Baremetal (Allocator) | ||
| --------- |
There was a problem hiding this comment.
nit: needs to match the length of the line above.
5 participants
This was on request from other maintainers, given that I've been de-facto acting as maintainer of the baremetal allocator stuff.
Let me know if this is too fine-grained to track.