Skip to content

[libc] Add dthorn as maintainer for allocator on baremetal #135203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

[libc] Add dthorn as maintainer for allocator on baremetal #135203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f6ae7
[libc] Add dthorn as maintainer for allocator on baremetal
mysterymath Apr 10, 2025
8847d65
Increase line length
mysterymath Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libc/Maintainers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ Baremetal
| Petr Hosek
| phosek\@google.com (email), `petrhosek <https://github.com/petrhosek>`_ (github)

Baremetal (Allocator)
Copy link
Member

@petrhosek petrhosek Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about making the allocator usable in non-baremetal environments as well (ideally we'd have a CMake option to select between system, libc and Scudo alllocator) so I wonder if this should say just "Allocator"?

Copy link
Contributor

@michaelrj-google michaelrj-google Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either is fine with me. Whatever you're up for claiming.

Copy link
Contributor Author

@mysterymath mysterymath Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've talked about this off and on, and IIRC there was a loose consensus that some other allocator should be the default for hosted OS-es. (Probably SCUDO.) It's just that it should be automatically configured if you don't ask for something different. The libc allocator will always be terrible in basically any non-embedded context, so I'm comfortable calling it a baremetal allocator (at least until something changes).

---------
Copy link
Contributor

@michaelrj-google michaelrj-google Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: needs to match the length of the line above.

Copy link
Contributor Author

@mysterymath mysterymath Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

| Daniel Thornburgh
| dthorn\@google.com (email), `mysterymath <https://github.com/mysterymath>`_ (github)

Fixed Point
-----------
| Leonard Chan
Expand Down
Loading