[clang][test][NFC] Use -fdriver-only over /dev/null

[ilovepi]

Tests should avoid using platform dependent behavior, like /dev/null
when possible. -fdriver-only should stop clang even earlier, and avoid
any non-diagnostic output.

[ilovepi]

• [clang][test][NFC] Use -fdriver-only over /dev/null #135255 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Paul Kirth (ilovepi)

Changes

Tests should avoid using platform dependent behavior, like /dev/null
when possible. -fdriver-only should stop clang even earlier, and avoid
any non-diagnostic output.

---

Full diff: https://github.com/llvm/llvm-project/pull/135255.diff

1 Files Affected:

• (modified) clang/test/Driver/openacc-no-cir.c (+3-3)

diff --git a/clang/test/Driver/openacc-no-cir.c b/clang/test/Driver/openacc-no-cir.c
index 891f175a001bb..5fa1e4e0c809f 100644
--- a/clang/test/Driver/openacc-no-cir.c
+++ b/clang/test/Driver/openacc-no-cir.c
@@ -1,6 +1,6 @@
-// RUN: %clang -fopenacc -S %s -o /dev/null 2>&1 | FileCheck %s -check-prefix=ERROR
-// RUN: %clang -fclangir -fopenacc -S %s -o /dev/null 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
-// RUN: %clang -fopenacc -fclangir -S %s -o /dev/null 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
+// RUN: %clang -fopenacc -S %s -o -fdriver-only 2>&1 | FileCheck %s -check-prefix=ERROR
+// RUN: %clang -fclangir -fopenacc -S %s -fdriver-only 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
+// RUN: %clang -fopenacc -fclangir -S %s -fdriver-only 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
 
 // ERROR: OpenACC directives will result in no runtime behavior; use -fclangir to enable runtime effect
 // NOERROR-NOT: OpenACC directives

[llvmbot]

@llvm/pr-subscribers-clang-driver

Author: Paul Kirth (ilovepi)

Changes

Tests should avoid using platform dependent behavior, like /dev/null
when possible. -fdriver-only should stop clang even earlier, and avoid
any non-diagnostic output.

---

Full diff: https://github.com/llvm/llvm-project/pull/135255.diff

1 Files Affected:

• (modified) clang/test/Driver/openacc-no-cir.c (+3-3)

diff --git a/clang/test/Driver/openacc-no-cir.c b/clang/test/Driver/openacc-no-cir.c
index 891f175a001bb..5fa1e4e0c809f 100644
--- a/clang/test/Driver/openacc-no-cir.c
+++ b/clang/test/Driver/openacc-no-cir.c
@@ -1,6 +1,6 @@
-// RUN: %clang -fopenacc -S %s -o /dev/null 2>&1 | FileCheck %s -check-prefix=ERROR
-// RUN: %clang -fclangir -fopenacc -S %s -o /dev/null 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
-// RUN: %clang -fopenacc -fclangir -S %s -o /dev/null 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
+// RUN: %clang -fopenacc -S %s -o -fdriver-only 2>&1 | FileCheck %s -check-prefix=ERROR
+// RUN: %clang -fclangir -fopenacc -S %s -fdriver-only 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
+// RUN: %clang -fopenacc -fclangir -S %s -fdriver-only 2>&1 | FileCheck %s --allow-empty -check-prefix=NOERROR
 
 // ERROR: OpenACC directives will result in no runtime behavior; use -fclangir to enable runtime effect
 // NOERROR-NOT: OpenACC directives

[erichkeane]

This one shouldn't work. We explicitly don't diagnose this in non-codegen invocations.

[efriedma-quic]

-o -fdriver-only?

[ilovepi]

Ah, probably why the test passed 🤦

[MaskRay]

/dev/null works on Windows

utils/lit/lit/TestRunner.py
55:# Use temporary files to replace /dev/null on Windows.
57:kDevNull = "/dev/null"

If you are adjusting the test, also insert error: prefix for error messages

[ilovepi]

This one shouldn't work. We explicitly don't diagnose this in non-codegen invocations.

That's surprising, but if that's the case, I don't think this patch makes much sense.