Skip to content

Conversation

@pedroclobo
Copy link
Member

A poison vector should be used when performing an identity shuffle.

A `poison` vector should be used when performing an identity shuffle.
@llvmbot
Copy link
Member

llvmbot commented Apr 13, 2025

@llvm/pr-subscribers-backend-hexagon

Author: Pedro Lobo (pedroclobo)

Changes

A poison vector should be used when performing an identity shuffle.


Full diff: https://github.com/llvm/llvm-project/pull/135555.diff

1 Files Affected:

  • (modified) llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp (+4-4)
diff --git a/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp b/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
index f800446592c06..d0f14d8ad7286 100644
--- a/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
@@ -2318,9 +2318,9 @@ auto HexagonVectorCombine::insertb(IRBuilderBase &Builder, Value *Dst,
   assert(0 <= Where && Where + Length <= DstLen);
 
   int P2Len = PowerOf2Ceil(SrcLen | DstLen);
-  auto *Undef = UndefValue::get(getByteTy());
-  Value *P2Src = vresize(Builder, Src, P2Len, Undef);
-  Value *P2Dst = vresize(Builder, Dst, P2Len, Undef);
+  auto *Poison = PoisonValue::get(getByteTy());
+  Value *P2Src = vresize(Builder, Src, P2Len, Poison);
+  Value *P2Dst = vresize(Builder, Dst, P2Len, Poison);
 
   SmallVector<int, 256> SMask(P2Len);
   for (int i = 0; i != P2Len; ++i) {
@@ -2331,7 +2331,7 @@ auto HexagonVectorCombine::insertb(IRBuilderBase &Builder, Value *Dst,
   }
 
   Value *P2Insert = Builder.CreateShuffleVector(P2Dst, P2Src, SMask, "shf");
-  return vresize(Builder, P2Insert, DstLen, Undef);
+  return vresize(Builder, P2Insert, DstLen, Poison);
 }
 
 auto HexagonVectorCombine::vlalignb(IRBuilderBase &Builder, Value *Lo,

@pedroclobo pedroclobo requested a review from nunoplopes April 15, 2025 20:32
@androm3da androm3da requested a review from iajbar April 16, 2025 15:35
@pedroclobo pedroclobo merged commit 4d75691 into llvm:main Apr 19, 2025
9 of 11 checks passed
@pedroclobo pedroclobo deleted the hexagon-poison branch April 19, 2025 16:15
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
A `poison` vector should be used when performing an identity shuffle.

Co-authored-by: Nuno Lopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants