Skip to content

Conversation

@kmpeng
Copy link
Contributor

@kmpeng kmpeng commented Apr 18, 2025

When SPIRV-Tools is enabled, tests that specify the target environment vulkan1.3 in the validation step fail. This is because SPIRV-Tools seems to have grown some capability checks for vulkan 1.3. The failing tests are:

  • CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
  • CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll

For now, the fix is to XFAIL these tests to unblock the pipeline.

Issue #136344 tracks the long-term solution for this.

@llvmbot
Copy link
Member

llvmbot commented Apr 18, 2025

@llvm/pr-subscribers-backend-spir-v

Author: Kaitlin Peng (kmpeng)

Changes

Temporarily fixes #136049.

SPIRV-Tools seems to have grown some capability checks for vulkan 1.3, which broke:

  • CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
  • CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll

For now the fix is to XFAIL these tests to unblock the pipeline.


Full diff: https://github.com/llvm/llvm-project/pull/136343.diff

2 Files Affected:

  • (modified) llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll (+3)
  • (modified) llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll (+3)
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
index 83caa62150cda..f5be558929b52 100644
--- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
+++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
@@ -1,6 +1,9 @@
 ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
 
+; TODO: This test currently fails when --target-env vulkan1.3 is specified.
+; XFAIL: *
+
 ; CHECK-DAG:        %[[#int:]] = OpTypeInt 32 0
 ; CHECK-DAG:        %[[#ptr_Input_int:]] = OpTypePointer Input %[[#int]]
 ; CHECK-DAG:        %[[#LocalInvocationIndex:]] = OpVariable %[[#ptr_Input_int]] Input
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
index e0e04dd0faf58..64f3287f43416 100644
--- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
+++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
@@ -1,6 +1,9 @@
 ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
 
+; TODO: This test currently fails when --target-env vulkan1.3 is specified.
+; XFAIL: *
+
 ; Make sure SPIRV operation function calls for smoothstep are lowered correctly.
 
 ; CHECK-DAG: %[[#op_ext_glsl:]] = OpExtInstImport "GLSL.std.450"

@kmpeng kmpeng merged commit a79e257 into llvm:main Apr 18, 2025
12 checks passed
@kmpeng kmpeng self-assigned this Apr 21, 2025
@kmpeng kmpeng removed this from HLSL Support Apr 21, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…sts (llvm#136343)

When SPIRV-Tools is enabled, tests that specify the target environment
`vulkan1.3` in the validation step fail. This is because SPIRV-Tools
seems to have [grown some capability checks for vulkan
1.3](KhronosGroup/SPIRV-Tools@7e41c71).
The failing tests are:
- `CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll`
- `CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll`

For now, the fix is to XFAIL these tests to unblock the pipeline.

Issue llvm#136344 tracks the long-term solution for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants