Skip to content

update_mir_test_checks: keep commment embedded in MIR #140016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

update_mir_test_checks: keep commment embedded in MIR #140016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75947e2
update_mir_test_checks: keep commment embedded in MIR
ruiling May 12, 2025
9b809b3
update_mir_test_checks: update one test for this
ruiling May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/x86-dead-def.mir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ body: |
bb.1:
dead %0:gr32(s32) = G_CONSTANT i32 0
dead undef %1.sub_32bit:gr64(s32) = G_CONSTANT i32 1
; Keep meaningful comment.
undef %2.sub_32bit:gr64(s32) = G_CONSTANT i32 2
...
1 change: 1 addition & 0 deletions llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/x86-dead-def.mir.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ body: |
; CHECK-NEXT: undef [[C2:%[0-9]+]].sub_32bit:gr64(s32) = G_CONSTANT i32 2
dead %0:gr32(s32) = G_CONSTANT i32 0
dead undef %1.sub_32bit:gr64(s32) = G_CONSTANT i32 1
; Keep meaningful comment.
undef %2.sub_32bit:gr64(s32) = G_CONSTANT i32 2
...
4 changes: 2 additions & 2 deletions llvm/utils/update_mir_test_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,9 @@ def mangle_vreg(opcode, current_names):


def should_add_line_to_output(input_line, prefix_set):
# Skip any check lines that we're handling as well as comments
# Skip any check lines that we're handling as well as blank comment.
m = common.CHECK_RE.match(input_line)
if (m and m.group(1) in prefix_set) or re.search("^[ \t]*;", input_line):
if (m and m.group(1) in prefix_set) or input_line.strip() == ";":
return False
return True

Expand Down