[mlir][tosa] Fix indexing in TosaToTensor

[shay-kl]

Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.

[llvmbot]

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-tosa

Author: Shay Kleiman (shay-kl)

Changes

Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.

---

Full diff: https://github.com/llvm/llvm-project/pull/140906.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp (+2-1)

diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
index 5f23a33049f87..4f565607e2167 100644
--- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
+++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
@@ -362,7 +362,8 @@ class PadConverter : public OpConversionPattern<tosa::PadOp> {
     // Setup the default constantAttr.
 
     Value padConstant = rewriter.createOrFold<tensor::ExtractOp>(
-        loc, padOp.getPadConst(), ValueRange({}));
+      loc, padOp.getPadConst(),
+      ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));
 
     if (!padConstant) {
       return rewriter.notifyMatchFailure(

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[shay-kl]

The issue seems to be from 0c34d7a @lhutton1

[lhutton1]

Thanks @shay-kl, LGTM. I think the related change is actually: #125297

[shay-kl]

I don't have permissions, can you please land it?