Skip to content

[VPlanUtils] Use TypeSwitch to simplify isSingleScalar(). nfc #141074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mel-Chen wants to merge 4 commits into from
Closed

[VPlanUtils] Use TypeSwitch to simplify isSingleScalar(). nfc #141074

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4703c1c
nfnfc, use TypeSwitch
Mel-Chen May 22, 2025
6be5da5
nfc, correct comment
Mel-Chen May 23, 2025
d8da3b4
nfc, remove getDefiningRecipe()
Mel-Chen May 23, 2025
8e441c2
nfc, replace VPValue with auto
Mel-Chen May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 32 additions & 23 deletions llvm/lib/Transforms/Vectorize/VPlanUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#define LLVM_TRANSFORMS_VECTORIZE_VPLANUTILS_H

#include "VPlan.h"
#include "llvm/ADT/TypeSwitch.h"

namespace llvm {
class ScalarEvolution;
Expand Down Expand Up @@ -59,29 +60,37 @@ inline bool isSingleScalar(const VPValue *VPV) {
if (VPV->isLiveIn())
return true;

if (auto *Rep = dyn_cast<VPReplicateRecipe>(VPV)) {
const VPRegionBlock *RegionOfR = Rep->getParent()->getParent();
// Don't consider recipes in replicate regions as uniform yet; their first
// lane cannot be accessed when executing the replicate region for other
// lanes.
if (RegionOfR && RegionOfR->isReplicator())
return false;
return Rep->isSingleScalar() || (PreservesUniformity(Rep->getOpcode()) &&
all_of(Rep->operands(), isSingleScalar));
}
if (isa<VPWidenGEPRecipe, VPDerivedIVRecipe, VPBlendRecipe>(VPV))
return all_of(VPV->getDefiningRecipe()->operands(), isSingleScalar);
if (auto *WidenR = dyn_cast<VPWidenRecipe>(VPV)) {
return PreservesUniformity(WidenR->getOpcode()) &&
all_of(WidenR->operands(), isSingleScalar);
}
if (auto *VPI = dyn_cast<VPInstruction>(VPV))
return VPI->isSingleScalar() || VPI->isVectorToScalar() ||
(PreservesUniformity(VPI->getOpcode()) &&
all_of(VPI->operands(), isSingleScalar));

// VPExpandSCEVRecipes must be placed in the entry and are alway uniform.
return isa<VPExpandSCEVRecipe>(VPV);
return TypeSwitch<const VPValue *, bool>(VPV)
.Case<VPReplicateRecipe>([&](const auto *Rep) {
const VPRegionBlock *RegionOfR = Rep->getParent()->getParent();
// Don't consider recipes in replicate regions as uniform yet; their
// first lane cannot be accessed when executing the replicate region for
// other lanes.
if (RegionOfR && RegionOfR->isReplicator())
return false;
return Rep->isSingleScalar() ||
(PreservesUniformity(Rep->getOpcode()) &&
all_of(Rep->operands(), isSingleScalar));
})
.Case<VPWidenGEPRecipe, VPDerivedIVRecipe, VPBlendRecipe>(
[&](const auto *R) {
return all_of(R->getDefiningRecipe()->operands(), isSingleScalar);
})
.Case<VPWidenRecipe>([&](const auto *WidenR) {
return PreservesUniformity(WidenR->getOpcode()) &&
all_of(WidenR->operands(), isSingleScalar);
})
.Case<VPInstruction>([&](const auto *VPI) {
return VPI->isSingleScalar() || VPI->isVectorToScalar() ||
(PreservesUniformity(VPI->getOpcode()) &&
all_of(VPI->operands(), isSingleScalar));
})
.Case<VPExpandSCEVRecipe>([](const VPValue *) {
// VPExpandSCEVRecipes must be placed in the entry and are alway
// uniform.
return true;
})
.Default([](const VPValue *) { return false; });
}

/// Return true if \p V is a header mask in \p Plan.
Expand Down
Loading