Skip to content

[NFC][clangd][test] add clang-tidy config to ensure test cases sandbox #141410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

[NFC][clangd][test] add clang-tidy config to ensure test cases sandbox #141410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac614ac
[NFC][clangd][test] add clang-tidy config to ensure test cases sandbox
HerrCai0907 May 25, 2025
42c5e71
disable clang-tidy
HerrCai0907 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang-tools-extra/clangd/test/Inputs/path-mappings/server/.clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
InheritParentConfig: false
Copy link
Member

@kadircet kadircet May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we running any tests in this directory? these inputs are usually copied to temp test directories, since you're not copying this over in any of the tests, is this really needed? (or do we have some tests that recursively copy everything?)

Copy link
Contributor Author

@HerrCai0907 HerrCai0907 May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path-mapping will copy all folder to tmp folder. but i agree disable clangtidy is better

3 changes: 3 additions & 0 deletions clang-tools-extra/clangd/test/system-include-extractor.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
# RUN: echo 'printf "End of search list.\r\n" >&2' >> %t.dir/bin/my_driver.sh
# RUN: chmod +x %t.dir/bin/my_driver.sh

# Create fake clang-tidy config to ensure sandbox
# RUN: echo 'InheritParentConfig: false' >> %t.dir/.clang-tidy
Copy link
Member

@kadircet kadircet May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this can you just pass -clang-tidy=0 to clangd invocations in this file? we shouldn't be testing/relying on any clang-tidy behavior in this test file.


# Create header files my/dir/a.h and my/dir2/b.h
# RUN: mkdir -p %t.dir/my/dir
# RUN: touch %t.dir/my/dir/a.h
Expand Down
Loading