[mlir] [docs] Minor documentation fix in mlir-reduce docs
#142479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir Author: Samarth Narang (snarang181) ChangesFixes #142460 Full diff: https://github.com/llvm/llvm-project/pull/142479.diff 1 Files Affected:
diff --git a/mlir/docs/Tools/mlir-reduce.md b/mlir/docs/Tools/mlir-reduce.md
index b60cdd799ba0c..224013899b440 100644
--- a/mlir/docs/Tools/mlir-reduce.md
+++ b/mlir/docs/Tools/mlir-reduce.md
@@ -31,7 +31,7 @@ results and different time complexity. You can run as
As mentioned, you need to provide a command to `mlir-reduce` which identifies
cases you're interested in. For each intermediate output generated during
reduction, `mlir-reduce` will run the command over the it, the script should
-returns 1 for interesting case, 0 otherwise. The sample script,
+returns 0 for an interesting case, 1 otherwise. The sample script,
```shell
mlir-opt -convert-vector-to-spirv $1 | grep "failed to materialize"
|
Contributor
Author
|
@qcolombet -- requesting your review here. |
joker-eph
reviewed
Jun 4, 2025
| cases you're interested in. For each intermediate output generated during | ||
| reduction, `mlir-reduce` will run the command over the it, the script should | ||
| returns 1 for interesting case, 0 otherwise. The sample script, | ||
| returns 0 for an interesting case, 1 otherwise. The sample script, |
Collaborator
There was a problem hiding this comment.
I don't quite get the change, can you elaborate? The existing sentence seems correct with respect to the code sample below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142460