[Flang] NFC: Update test to work on Mac #144253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%flang expands to flang -isysroot <SDK location> in Mac and probably other OS as well. `fc1` is only accepted as the first argument and hence in this case it fails. Use the %flang_fc1 option to correctly expand.
luporl
approved these changes
Jun 16, 2025
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
`%flang` expands to `flang -isysroot <SDK location>` in Mac and probably other OS as well. `fc1` is only accepted as the first argument and hence in this case it fails. Use the `%flang_fc1` option to correctly expand to `flang -fc1 -isysroot <SDK location>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%flangexpands toflang -isysroot <SDK location>in Mac and probably other OS as well.fc1is only accepted as the first argument and hence in this case it fails.Use the
%flang_fc1option to correctly expand toflang -fc1 -isysroot <SDK location>.