Skip to content

[NFC][mlir][tensor] Use ValueRange instead of SmallVector in tensor::createPadHighOp #144397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

[NFC][mlir][tensor] Use ValueRange instead of SmallVector in tensor::createPadHighOp #144397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Tensor/Utils/Utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace tensor {
// for _static_ dimensions.
PadOp createPadHighOp(RankedTensorType resType, Value source, Value pad,
bool nofold, Location loc, OpBuilder &builder,
SmallVector<Value> dynOutDims = {});
ValueRange dynOutDims = std::nullopt);

// Creates dim ops for each dynamic dimension of the ranked tensor argument and
// returns these as values.
Expand Down
3 changes: 1 addition & 2 deletions mlir/lib/Dialect/Tensor/Utils/Utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ using namespace mlir::tensor;

PadOp mlir::tensor::createPadHighOp(RankedTensorType resType, Value source,
Value pad, bool nofold, Location loc,
OpBuilder &b,
SmallVector<Value> dynOutDims) {
OpBuilder &b, ValueRange dynOutDims) {

// This assumption simplifies the following logic without limiting what's
// required _today_. If needed, we can relax it in the future.
Expand Down
Loading