[lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr #146686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not that we ever do that, because this is unused code, but if someone was debugging lldb I guess they'd call this. Was missed in llvm#145645 Relates to llvm#135208
Member
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesNot that we ever do that, because this is unused code, but if someone was debugging lldb I guess they'd call this. Was missed in #145645 Relates to #135208 Full diff: https://github.com/llvm/llvm-project/pull/146686.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
index 2e98e3c33acaf..40e2a9669e258 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
@@ -420,8 +420,7 @@ void DWARFFormValue::Dump(Stream &s) const {
DumpAddress(s.AsRawOstream(), uvalue, sizeof(uint64_t) * 2);
else
DumpAddress(s.AsRawOstream(), uvalue,
- 4 * 2); // 4 for DWARF32, 8 for DWARF64, but we don't
- // support DWARF64 yet
+ m_unit->GetFormParams().getRefAddrByteSize());
break;
}
case DW_FORM_ref1:
|
Collaborator
Author
|
@HemangGadhavi (can't add you to reviewers for whatever reason) |
Contributor
May be I do not have maintainer access yet ..?? Not sure. |
Collaborator
Author
That'll be it, for some reason I thought having a merged PR would imply you could review. |
Collaborator
Author
|
Well, you clearly can review but I cannot add you to reviewers 🤣 Permissions are such mysterious things. |
Michael137
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that we ever do that, because this is unused code, but if someone was debugging lldb I guess they'd call this.
Was missed in #145645
Relates to #135208