Skip to content

[lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr #146686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

[lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr #146686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d19a8f
[lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr
DavidSpickett Jul 2, 2025
742256d
simplify
DavidSpickett Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,8 @@ void DWARFFormValue::Dump(Stream &s) const {
case DW_FORM_ref_addr: {
assert(m_unit); // Unit must be valid for DW_FORM_ref_addr objects or we
// will get this wrong
if (m_unit->GetVersion() <= 2)
DumpAddress(s.AsRawOstream(), uvalue, sizeof(uint64_t) * 2);
else
DumpAddress(s.AsRawOstream(), uvalue,
4 * 2); // 4 for DWARF32, 8 for DWARF64, but we don't
// support DWARF64 yet
DumpAddress(s.AsRawOstream(), uvalue,
m_unit->GetFormParams().getRefAddrByteSize());
break;
}
case DW_FORM_ref1:
Expand Down
Loading