[libclc] Reduce include usage in OpenCL builtins #146840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenju-he
reviewed
Jul 4, 2025
frasercrmck
force-pushed
the
libclc-opencl-base-integer
branch
from
809436c to
000693b
Compare
This commit starts the process of reducing the amount of code included by OpenCL builtins, hopefully reducing build times in the process. It introduces a minimal OpenCL header - opencl-base.h - which includes only the OpenCL type definitions and the macros necessary for declaring/defining functions. Where the OpenCL builtin implementations would currently include the whole of <clc/opencl/clc.h>, which defines *all* OpenCL builtins, now they include only the specific declaration they need. This mirrors how the CLC builtins are defined.
frasercrmck
force-pushed
the
libclc-opencl-base-integer
branch
from
000693b to
23d28ce
Compare
frasercrmck
added a commit
to frasercrmck/llvm-project
that referenced
this pull request
Jul 7, 2025
This commit continues the work from llvm#146840 and extends it to the maths, geomtrics, common, and relational directories. All headers have include guards and, where appropriate, include the minimal code required for their specific definitions. Implementation files no longer include the large catch-all header of all OpenCL builtin declarations.
frasercrmck
added a commit
that referenced
this pull request
Jul 8, 2025
This commit continues the work from #146840 and extends it to the maths, geomtrics, common, and relational directories. All headers have include guards and, where appropriate, include the minimal code required for their specific definitions. Implementation files no longer include the large catch-all header of all OpenCL builtin declarations.
frasercrmck
added a commit
to frasercrmck/llvm-project
that referenced
this pull request
Jul 8, 2025
This commit finishes the work started in llvm#146840 and llvm#147276. It makes each OpenCL header self-contained and each implementation file include only the header it needs. It removes the need for a catch-all include file of all OpenCL builtin declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit starts the process of reducing the amount of code included by OpenCL builtins, hopefully reducing build times in the process.
It introduces a minimal OpenCL header - opencl-base.h - which includes only the OpenCL type definitions and the macros necessary for declaring/defining functions.
Where the OpenCL builtin implementations would currently include the whole of <clc/opencl/clc.h>, which defines all OpenCL builtins, now they include only the specific declaration they need.
This mirrors how the CLC builtins are defined.