Skip to content

Conversation

@kuhar
Copy link
Member

@kuhar kuhar commented Jul 4, 2025

Use the correct path to binding tests.
Also add a suggested ninja command to run tests.

Use the correct path to binding tests.
Also add a suggested ninja command to run tests.
@llvmbot llvmbot added the mlir label Jul 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 4, 2025

@llvm/pr-subscribers-mlir

Author: Jakub Kuderski (kuhar)

Changes

Use the correct path to binding tests.
Also add a suggested ninja command to run tests.


Full diff: https://github.com/llvm/llvm-project/pull/147092.diff

1 Files Affected:

  • (modified) mlir/docs/Bindings/Python.md (+4-2)
diff --git a/mlir/docs/Bindings/Python.md b/mlir/docs/Bindings/Python.md
index b8bd0f507a510..90796ea0801a2 100644
--- a/mlir/docs/Bindings/Python.md
+++ b/mlir/docs/Bindings/Python.md
@@ -51,7 +51,9 @@ python -m pip install --upgrade pip
 # packages will be installed there.
 python -m pip install -r mlir/python/requirements.txt
 
-# Now run `cmake`, `ninja`, et al.
+# Now run `cmake`, `ninja`, et al. For example, to run python bindings test only
+# using ninja:
+ninja check-mlir-python
 ```
 
 For interactive use, it is sufficient to add the
@@ -859,7 +861,7 @@ mutually exclusive with a more complete mapping of the backing constructs.
 
 ## Testing
 
-Tests should be added in the `test/Bindings/Python` directory and should
+Tests should be added in the `mlir/test/python` directory and should
 typically be `.py` files that have a lit run line.
 
 We use `lit` and `FileCheck` based tests:

@kuhar kuhar requested a review from bangtianliu July 4, 2025 17:40
@kuhar kuhar merged commit 8740ff8 into llvm:main Jul 4, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants