Skip to content

[NFC][SemaHLSL] Remove check dependent on non-deterministic root element association #148649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

[NFC][SemaHLSL] Remove check dependent on non-deterministic root element association #148649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad3211d
[NFC][SemaHLSL] Remove check dependent on non-deterministic order
inbelic Jul 14, 2025
e47d9bd
nfc, self-review: we can make it slightly stricter
inbelic Jul 14, 2025
fc9e943
remove redundant test-case
inbelic Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions clang/test/SemaHLSL/RootSignature-resource-ranges-err.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,25 +109,6 @@ void bad_root_signature_14() {}
#define DuplicatesRootSignature \
"CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"

// CHECK: [[@LINE-2]]:13: note: expanded from macro 'DuplicatesRootSignature'
// CHECK-NEXT: [[@LINE-3]] | "CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"
// CHECK-NEXT: | ^
// CHECK: [[@LINE-5]]:4: note: expanded from macro 'DuplicatesRootSignature'
// CHECK-NEXT: [[@LINE-6]] | "CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"
// CHECK-NEXT: | ^
// CHECK: [[@LINE-8]]:22: note: expanded from macro 'DuplicatesRootSignature'
// CHECK-NEXT: [[@LINE-9]] | "CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"
// CHECK-NEXT: | ^
// CHECK: [[@LINE-11]]:4: note: expanded from macro 'DuplicatesRootSignature'
// CHECK-NEXT: [[@LINE-12]] | "CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"
// CHECK-NEXT: | ^
// CHECK: [[@LINE-14]]:47: note: expanded from macro 'DuplicatesRootSignature'
// CHECK-NEXT: [[@LINE-15]] | "CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"
// CHECK-NEXT: | ^
// CHECK: [[@LINE-17]]:4: note: expanded from macro 'DuplicatesRootSignature'
// CHECK-NEXT: [[@LINE-18]] | "CBV(b0), CBV(b0), CBV(b0), DescriptorTable(CBV(b0, numDescriptors = 2))"
// CHECK-NEXT: | ^

// expected-error@+6 {{resource ranges b[0;0] and b[0;0] overlap within space = 0 and visibility = All}}
// expected-note@+5 {{overlapping resource range here}}
// expected-error@+4 {{resource ranges b[0;0] and b[0;0] overlap within space = 0 and visibility = All}}
Expand Down