Skip to content

[libc++][ranges] Ensure range access CPOs are provided in <iterator> #151745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libcxx/include/iterator
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,16 @@ template <class E> constexpr const E* data(initializer_list<E> il) noexcept;
# include <compare>
# include <concepts>

// [range.access.general]
# if _LIBCPP_STD_VER >= 20
# include <__ranges/access.h>
# include <__ranges/data.h>
# include <__ranges/empty.h>
# include <__ranges/rbegin.h>
# include <__ranges/rend.h>
# include <__ranges/size.h>
# endif

# if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header
# endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ static_assert(test(std::ranges::rend, a));
static_assert(test(std::ranges::size, a));
static_assert(test(std::ranges::ssize, a));

#if TEST_STD_VER >= 26
// static_assert(test(std::views::reserve_hint, a));
#endif

// [range.factories]
// views::empty<T> is not a CPO
static_assert(test(std::views::iota, 1));
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// REQUIRES: std-at-least-c++20

// [range.access.general]/1:
// In addition to being available via inclusion of the <ranges> header, the customization point objects in
// [range.access] are available when the header <iterator> is included.

#include <iterator>
#include <type_traits>

#include "test_macros.h"

template <class CPO, class... Args>
constexpr bool test(CPO& o, Args&&...) {
static_assert(std::is_const_v<CPO>);
static_assert(std::is_class_v<CPO>);
static_assert(std::is_trivially_copyable_v<CPO>);
static_assert(std::is_trivially_default_constructible_v<CPO>);

auto p = o;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto p = o;
auto p = o;
(void)o(args...); // to make sure the CPO can actually be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, given we actually call CPOs, it perhaps makes more sense to test both compile time and runtime invocability. I'm now changing the test file to .pass.cpp.

using T = decltype(p);

// The type of a customization point object, ignoring cv-qualifiers, shall model semiregular.
static_assert(std::semiregular<T>);

// The type T of a customization point object, ignoring cv-qualifiers, shall model...
static_assert(std::invocable<T&, Args...>);
static_assert(std::invocable<const T&, Args...>);
static_assert(std::invocable<T, Args...>);
static_assert(std::invocable<const T, Args...>);

return true;
}

int a[10];

static_assert(test(std::ranges::begin, a));
static_assert(test(std::ranges::end, a));
static_assert(test(std::ranges::cbegin, a));
static_assert(test(std::ranges::cdata, a));
static_assert(test(std::ranges::cend, a));
static_assert(test(std::ranges::crbegin, a));
static_assert(test(std::ranges::crend, a));
static_assert(test(std::ranges::data, a));
static_assert(test(std::ranges::empty, a));
static_assert(test(std::ranges::rbegin, a));
static_assert(test(std::ranges::rend, a));
static_assert(test(std::ranges::size, a));
static_assert(test(std::ranges::ssize, a));

#if TEST_STD_VER >= 26
// static_assert(test(std::views::reserve_hint, a));
#endif
Loading