-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[libc++][ranges] Ensure range access CPOs are provided in <iterator>
#151745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
d73c62f
48bdb72
bd0ac1c
83ad269
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,60 @@ | ||||||||
//===----------------------------------------------------------------------===// | ||||||||
// | ||||||||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||||||||
// See https://llvm.org/LICENSE.txt for license information. | ||||||||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||||||||
// | ||||||||
//===----------------------------------------------------------------------===// | ||||||||
|
||||||||
// REQUIRES: std-at-least-c++20 | ||||||||
|
||||||||
// [range.access.general]/1: | ||||||||
// In addition to being available via inclusion of the <ranges> header, the customization point objects in | ||||||||
// [range.access] are available when the header <iterator> is included. | ||||||||
frederick-vs-ja marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
|
||||||||
#include <iterator> | ||||||||
#include <type_traits> | ||||||||
|
||||||||
#include "test_macros.h" | ||||||||
|
||||||||
template <class CPO, class... Args> | ||||||||
constexpr bool test(CPO& o, Args&&...) { | ||||||||
frederick-vs-ja marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
static_assert(std::is_const_v<CPO>); | ||||||||
static_assert(std::is_class_v<CPO>); | ||||||||
static_assert(std::is_trivially_copyable_v<CPO>); | ||||||||
static_assert(std::is_trivially_default_constructible_v<CPO>); | ||||||||
|
||||||||
auto p = o; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, given we actually call CPOs, it perhaps makes more sense to test both compile time and runtime invocability. I'm now changing the test file to |
||||||||
using T = decltype(p); | ||||||||
|
||||||||
// The type of a customization point object, ignoring cv-qualifiers, shall model semiregular. | ||||||||
static_assert(std::semiregular<T>); | ||||||||
|
||||||||
// The type T of a customization point object, ignoring cv-qualifiers, shall model... | ||||||||
static_assert(std::invocable<T&, Args...>); | ||||||||
static_assert(std::invocable<const T&, Args...>); | ||||||||
static_assert(std::invocable<T, Args...>); | ||||||||
static_assert(std::invocable<const T, Args...>); | ||||||||
|
||||||||
return true; | ||||||||
} | ||||||||
|
||||||||
int a[10]; | ||||||||
|
||||||||
static_assert(test(std::ranges::begin, a)); | ||||||||
static_assert(test(std::ranges::end, a)); | ||||||||
static_assert(test(std::ranges::cbegin, a)); | ||||||||
static_assert(test(std::ranges::cdata, a)); | ||||||||
static_assert(test(std::ranges::cend, a)); | ||||||||
static_assert(test(std::ranges::crbegin, a)); | ||||||||
static_assert(test(std::ranges::crend, a)); | ||||||||
static_assert(test(std::ranges::data, a)); | ||||||||
static_assert(test(std::ranges::empty, a)); | ||||||||
static_assert(test(std::ranges::rbegin, a)); | ||||||||
static_assert(test(std::ranges::rend, a)); | ||||||||
static_assert(test(std::ranges::size, a)); | ||||||||
static_assert(test(std::ranges::ssize, a)); | ||||||||
|
||||||||
#if TEST_STD_VER >= 26 | ||||||||
// static_assert(test(std::views::reserve_hint, a)); | ||||||||
#endif |
Uh oh!
There was an error while loading. Please reload this page.