Skip to content

[clang] Inline static helper function in Compilation.cpp #152875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2025
Merged

[clang] Inline static helper function in Compilation.cpp #152875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df0db4
Inline `InputsOk` function in `clang/lib/Driver/Compilation.cpp`
Thibault-Monnier Aug 9, 2025
25d6d40
Merge branch 'llvm:main' into main
Thibault-Monnier Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions clang/lib/Driver/Compilation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,6 @@ static bool ActionFailed(const Action *A,
return false;
}

static bool InputsOk(const Command &C,
const FailingCommandList &FailingCommands) {
return !ActionFailed(&C.getSource(), FailingCommands);
}

void Compilation::ExecuteJobs(const JobList &Jobs,
FailingCommandList &FailingCommands,
bool LogOnly) const {
Expand All @@ -245,7 +240,7 @@ void Compilation::ExecuteJobs(const JobList &Jobs,
// In all but CLMode, execute all the jobs unless the necessary inputs for the
// job is missing due to previous failures.
for (const auto &Job : Jobs) {
if (!InputsOk(Job, FailingCommands))
if (ActionFailed(&Job.getSource(), FailingCommands))
continue;
const Command *FailingCommand = nullptr;
if (int Res = ExecuteCommand(Job, FailingCommand, LogOnly)) {
Expand Down