[NFC][MC][GOFF] Use llvm_unreachable for unreachable case
#152930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mc Author: Abhishek Kaushik (abhishek-kaushik22) ChangesFull diff: https://github.com/llvm/llvm-project/pull/152930.diff 1 Files Affected:
diff --git a/llvm/lib/MC/MCAsmInfoGOFF.cpp b/llvm/lib/MC/MCAsmInfoGOFF.cpp
index 0a5d1927b1a22..d0f931d03d532 100644
--- a/llvm/lib/MC/MCAsmInfoGOFF.cpp
+++ b/llvm/lib/MC/MCAsmInfoGOFF.cpp
@@ -72,7 +72,7 @@ static void emitCATTR(raw_ostream &OS, StringRef Name, GOFF::ESDRmode Rmode,
OS << "64";
break;
case GOFF::ESD_RMODE_None:
- break;
+ llvm_unreachable("GOFF::ESD_RMODE_None should not be handled here");
}
OS << ')';
}
|
MaskRay
reviewed
Aug 11, 2025
llvm/lib/MC/MCAsmInfoGOFF.cpp
Outdated
| @@ -72,7 +72,7 @@ static void emitCATTR(raw_ostream &OS, StringRef Name, GOFF::ESDRmode Rmode, | |||
| OS << "64"; | |||
| break; | |||
| case GOFF::ESD_RMODE_None: | |||
| break; | |||
| llvm_unreachable("GOFF::ESD_RMODE_None should not be handled here"); | |||
There was a problem hiding this comment.
I would move GOFF::ESD_RMODE_None: above to make it clear that this case has already been handled and use an empty llvm_unreachable as it's obvious.
abhishek-kaushik22
changed the title
llvm_unreachable for unreachable casellvm_unreachable for unreachable case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.