[NFC][MC][GOFF] Use llvm_unreachable for unreachable case

[abhishek-kaushik22]

No description provided.

[llvmbot]

@llvm/pr-subscribers-mc

Author: Abhishek Kaushik (abhishek-kaushik22)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/152930.diff

1 Files Affected:

• (modified) llvm/lib/MC/MCAsmInfoGOFF.cpp (+1-1)

diff --git a/llvm/lib/MC/MCAsmInfoGOFF.cpp b/llvm/lib/MC/MCAsmInfoGOFF.cpp
index 0a5d1927b1a22..d0f931d03d532 100644
--- a/llvm/lib/MC/MCAsmInfoGOFF.cpp
+++ b/llvm/lib/MC/MCAsmInfoGOFF.cpp
@@ -72,7 +72,7 @@ static void emitCATTR(raw_ostream &OS, StringRef Name, GOFF::ESDRmode Rmode,
       OS << "64";
       break;
     case GOFF::ESD_RMODE_None:
-      break;
+      llvm_unreachable("GOFF::ESD_RMODE_None should not be handled here");
     }
     OS << ')';
   }

[MaskRay]

I would move GOFF::ESD_RMODE_None: above to make it clear that this case has already been handled and use an empty llvm_unreachable as it's obvious.

[MaskRay]

The title can mention GOFF