Skip to content

[NFC][MC][GOFF] Use llvm_unreachable for unreachable case #152930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

[NFC][MC][GOFF] Use llvm_unreachable for unreachable case #152930

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5a1ec6
[NFC][MC] Use `llvm_unreachable` for unreachable case
abhishek-kaushik22 Aug 10, 2025
9803cb9
Update MCAsmInfoGOFF.cpp
abhishek-kaushik22 Aug 11, 2025
9de085c
Merge branch 'main' into unreachable
abhishek-kaushik22 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/MC/MCAsmInfoGOFF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ static void emitCATTR(raw_ostream &OS, StringRef Name, GOFF::ESDRmode Rmode,
OS << "64";
break;
case GOFF::ESD_RMODE_None:
break;
llvm_unreachable("GOFF::ESD_RMODE_None should not be handled here");
Copy link
Member

@MaskRay MaskRay Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move GOFF::ESD_RMODE_None: above to make it clear that this case has already been handled and use an empty llvm_unreachable as it's obvious.

}
OS << ')';
}
Expand Down